Skip to content

feat: Upgrade to selenium 4.35.0 #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 13, 2025
Merged

feat: Upgrade to selenium 4.35.0 #2327

merged 4 commits into from
Aug 13, 2025

Conversation

asolntsev
Copy link
Contributor

@asolntsev asolntsev commented Aug 12, 2025 •
edited by mykola-mokhnach
Loading

Change list

Upgraded Selenium from 4.34.0 to 4.35.0

BREAKING CHANGE: Removed all deprecated methods with Selenium's Location and LocationContext (these classes have been removed in Selenium 4.35.0)

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 12, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@asolntsev asolntsev mentioned this pull request Aug 12, 2025
Closed
@asolntsev asolntsev force-pushed the update/selenium-4.35.0 branch from c6237ad to 1bc2d25 Compare August 12, 2025 21:57
@asolntsev asolntsev changed the title Upgrade to selenium 4.35.0 BREAKING CHANGE: Upgrade to selenium 4.35.0 Aug 12, 2025
@asolntsev asolntsev changed the title BREAKING CHANGE: Upgrade to selenium 4.35.0 build(deps): Upgrade to selenium 4.35.0 Aug 12, 2025
@asolntsev
feat: remove all Location-related methods
31137eb 
classes `Location` and `LocationContext` have been removed in Selenium 4.35.0
@asolntsev asolntsev force-pushed the update/selenium-4.35.0 branch from 1bc2d25 to 69c5450 Compare August 12, 2025 22:09
@mykola-mokhnach
Copy link
Contributor

We should also update the version compatibility matrix at https://github.com/appium/java-client?tab=readme-ov-file#compatibility-matrix

@mykola-mokhnach
Copy link
Contributor

mykola-mokhnach commented Aug 13, 2025 •
edited
Loading

Also it should probably be a major version bump because the change is actually breaking

cc @valfirst

@asolntsev asolntsev force-pushed the update/selenium-4.35.0 branch from 69c5450 to 072f74e Compare August 13, 2025 07:27
@rosolko rosolko mentioned this pull request Aug 13, 2025
Merged
@asolntsev
Copy link
Contributor Author

@mykola-mokhnach @valfirst Updated compatibility matrix and bumped version number from 9.5.0 to 9.6.0

@mykola-mokhnach mykola-mokhnach mentioned this pull request Aug 13, 2025
Closed
mykola-mokhnach
mykola-mokhnach reviewed Aug 13, 2025
View reviewed changes
mykola-mokhnach
mykola-mokhnach reviewed Aug 13, 2025
View reviewed changes
mykola-mokhnach
mykola-mokhnach reviewed Aug 13, 2025
View reviewed changes
@asolntsev asolntsev force-pushed the update/selenium-4.35.0 branch from 072f74e to 4c7cd87 Compare August 13, 2025 17:13
@asolntsev asolntsev force-pushed the update/selenium-4.35.0 branch from 4c7cd87 to 8521aaf Compare August 13, 2025 17:13
@mykola-mokhnach mykola-mokhnach changed the title build(deps): Upgrade to selenium 4.35.0 feat: Upgrade to selenium 4.35.0 Aug 13, 2025
@mykola-mokhnach mykola-mokhnach merged commit b2de541 into appium:master Aug 13, 2025
8 of 9 checks passed
@asolntsev asolntsev deleted the update/selenium-4.35.0 branch August 13, 2025 17:37
@asolntsev
Copy link
Contributor Author

Released as io.appium:java-client:10.0.0

@KazuCocoa KazuCocoa added the size:S contribution size: S label Sep 1, 2025
@KazuCocoa
Copy link
Member

Hi @asolntsev, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you!

@asolntsev
Copy link
Contributor Author

Hi @jlipps and @KazuCocoa

My OpenCollective account is https://opencollective.com/andreisolntsev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@SrinivasanTarget SrinivasanTarget Awaiting requested review from SrinivasanTarget SrinivasanTarget is a code owner

@saikrishna321 saikrishna321 Awaiting requested review from saikrishna321 saikrishna321 is a code owner

@valfirst valfirst Awaiting requested review from valfirst valfirst is a code owner

Assignees

No one assigned

Labels

size:S contribution size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asolntsev @mykola-mokhnach @KazuCocoa